Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rails dependency to >= 3.2 #15

Merged
merged 1 commit into from
Aug 30, 2013
Merged

Conversation

joejwright
Copy link
Contributor

I just tested this with rails 4.0.0 and everything looks fine.

@fgrehm
Copy link
Owner

fgrehm commented Aug 20, 2013

@jwrigh13 it's good to know that it works! we just need to fix the specs before merging in. I'm heading on vacation today for a week but will have a look at it once I'm back :) thanks!

@zealoushacker
Copy link

Also, why would you guys require rails dependency to be >= 3.2, when it's backwards compatible with older rails versions? I just got this while trying to bundle install letter_opener_web in a rails 3.0.19 app, to fix the vagrant-related issues:

Bundler could not find compatible versions for gem "rails":
  In snapshot (Gemfile.lock):
    rails (3.0.19)

  In Gemfile:
    letter_opener_web (~> 1.0.3) ruby depends on
      rails (~> 3.2) ruby

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

@zealoushacker
Copy link

Ah, I think 3.1.0 would be minimum, due to usage of some methods like isolate_namespace

@zealoushacker
Copy link

Never mind, looks like 3.2.0 would be required due to some other dependencies :(

All good, 👍

@fgrehm fgrehm merged commit 9e14556 into fgrehm:master Aug 30, 2013
@fgrehm
Copy link
Owner

fgrehm commented Aug 30, 2013

@zealoushacker MERGED! tks for the help :) the new version will be available on rubygems in a few

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants