Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dismiss all pending dialog requests #3

Open
eskema opened this issue Jun 12, 2022 · 8 comments
Open

dismiss all pending dialog requests #3

eskema opened this issue Jun 12, 2022 · 8 comments

Comments

@eskema
Copy link

eskema commented Jun 12, 2022

right now, everytime there's a window.nostr.nip04.decrypt, it opens a dialog and we have to go one by one. It would be better to have an option to act on all requests at once, otherwise, this can be very painful in the future if there's a high number of messages to decrypt.

@Giszmo
Copy link
Contributor

Giszmo commented Sep 13, 2022

There is a button "forever" but it doesn't prevent a popup-flood the next time around, so I'm not sure what it does. Or maybe the plugin falls victim to my "delete all cookies when I close the browser" setting?

@monlovesmango
Copy link
Contributor

I think this happened if you didn't already have a permissions object saved and you try to set permissions for new host. just ran into this and making pr now.

as far as 'forever' is concerned, you can only have one permission at a time per host it seems. is of you say authorize reading pubkey forever, but then say authorize decrypting messages for 5 min, the later permission will overwrite the former.

@fiatjaf would you be interested in me updating permissions to be level specific per host?

@monlovesmango
Copy link
Contributor

@eskema can you confirm this is fixed for you now? if so should we close this issue? make sure your nos2x extension is updated to 1.5.2

@eskema
Copy link
Author

eskema commented Dec 16, 2022

I did a quick test, and I still get one dialog popup per message on the first run.

@monlovesmango
Copy link
Contributor

you using firefox or chrome? works for me on chrome.

@monlovesmango
Copy link
Contributor

@eskema are you still experiencing this? I haven't had it happen since the fix.

@eskema
Copy link
Author

eskema commented Jan 22, 2023

@eskema are you still experiencing this? I haven't had it happen since the fix.

I haven't been messing with kind-4 so don't really know if it's resolved.. feel free to close this if you think it's resolved, as I don't think i'll use the same method anyway and I should be able to avoid this even if not resolved..

@fiatjaf
Copy link
Owner

fiatjaf commented Jan 23, 2023

It is not resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants