Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in sha 256 #231

Closed
isaacvr opened this issue Oct 31, 2019 · 0 comments
Closed

Bug in sha 256 #231

isaacvr opened this issue Oct 31, 2019 · 0 comments
Labels
bug Something isn't working critical-security firmware MCU firmware help wanted Extra attention is needed Milestone v.1.0.0 question Further information is requested
Milestone
v1

Comments

@isaacvr
Copy link
Contributor

isaacvr commented Oct 31, 2019

Describe the bug

Environment information:

  • Linux 4.19.0-1-amd64 x86_64

Steps to Reproduce
Steps to reproduce the behavior:

    uint8_t digest[SHA256_DIGEST_LENGTH] = {0};
    int seed = rand();
    compute_sha256sum((const uint8_t*)seed, digest, sizeof(seed));

Actual behavior
Received signal 11 (Segmentation fault)

Expected behavior
Any input message(0 <= len < 2^64) should generate a 256 bits hash.
https://crypto.stackexchange.com/a/42033

Additional context
https://github.com/skycoin/hardware-wallet/issues/84
skycoin/libskycoin#34

Possible implementation
TODO
@isaacvr isaacvr added bug Something isn't working critical-security firmware MCU firmware help wanted Extra attention is needed Milestone v.1.0.0 question Further information is requested labels Oct 31, 2019
@isaacvr isaacvr added this to the v1 milestone Oct 31, 2019
@isaacvr isaacvr closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working critical-security firmware MCU firmware help wanted Extra attention is needed Milestone v.1.0.0 question Further information is requested
Projects
None yet
Milestone
v1
Development

No branches or pull requests
1 participant
@isaacvr