Fixes #250 - Add boolean option for passphrase #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this require changes in go library as well ? @stdevAdrianPaez if so what's the PR ? |
…assphrase_for_signing_transactions
…e stdevAdrianPaez_t63_edit_tx_messages_for_passphrase_option branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250
Changes:
with_passphraseoption tofsm_getKeyPairAtIndex. This allows you to enable or not the use of a passphrase for mnemonic and, therefore, to use two generations of different addresses, as long as the device has the passphrase option enabled.fsm_getKeyPairAtIndex) outside the signing process, the argumentwith_passphraseis passed astrue, because before this change that was the behavior. Note that in the future the selection of passphrase or not, should be considered in the future in these cases.Does this change need to mentioned in CHANGELOG.md?
yes
Requires testing
yes
Comments about testing , should you have some