Bootloader issues

[isaacvr]

In general:

• We need to get rid of the static asserts in files. For example in storage.c. (no, see comments below )

rng.h

• We need to change the include structure. Because now the way it compiles is not appropriate.

signatures.c:

• why do need SIG_OK, SIG_FAIL for signatures ok, if it just can return true or false
• writing the same code thrice isnt the best way. I think that better write a cycle.

bootloader.c:

• Here button is checked after 100000 cycles of nop, while some of button is pressed. What is the sense of it, because user can quick press in such way, that bootloader won't see it. And in this time processor is literally doing nothing, so it is better to all this time just checking, if button was pressed

firmware_sign_split.py:

what is the sense of this file, if it this never used ?

usb.c:

• Here is checking if new firmware is valid and then,if not, wiped from skywallet, but instead just wiped backup of meta, which is not important, because never used(in the next line it is replaced by new meta.
• Also multiple times are repeating lines from here to here, so would be good to make function from them.
• Test of the functionality
  HERE.

1. Are you confident that this number is good enough to test the uniform distribution? Link
2. CPU status is not implemented yet Link . Is it ok?
3. Can you give me a detailed description of the USB test HERE?

Created by @RomanMilishchuk and @YuraYelisieiev