Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Bitcoin transactions #362

Open
4 of 14 tasks
olemis opened this issue Nov 11, 2019 · 1 comment
Open
4 of 14 tasks

Sign Bitcoin transactions #362

olemis opened this issue Nov 11, 2019 · 1 comment
Labels
bitcoin Bitcoin support firmware MCU firmware stdev wip
Milestone

Comments

@olemis
Copy link
Collaborator

olemis commented Nov 11, 2019

Feature description

Sign Bitcoin transactions. If complex , at the beginning use P2PKH only.

Is your feature request related to a problem? Please describe.
Implement messages for a finite state machine to sign Bitcoin transactions.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

Skycoin transaction signing state machine

Message for distributing BIP44 address should be already implemented. Just needs correct cointype value specified in message's Bip44AddrIndex struct.
Similar state machine for Skycoin , and for Bitcoin exist. Feel free to consider them as a reference.

Possible implementation

  • Move Skycoin-specific messages onto a new messages-skycoin.proto file in protob repository.
  • Add Bitcoin-specific messages definition in messages-bitcoin.proto
  • Move Skycoin-specific handlers from fsm.c onto fsm_sky.c (same for headers if needed)
  • Move implementations of functions selected above from fsm_impl.c onto fsm_sky_impl.c (same for headers if needed)
  • Add new fsm_btc.c for Bitcoin messages handlers
  • Add new fsm_btc_impl.c for Bitcoin message implementations
  • Define Bitcoin signing state machine
  • Create issue in fibercrypto/docs for documenting Bitcoin signing state machine
  • Implement Bitcoin signing messages .
  • Support for P2PKH
  • Support for P2SH (if too complex or lengthy create new issue and add reference)
  • Support for P2MS (if too complex or lengthy create new issue and add reference)
  • Research other payment modes and add issues if anything relevant identified.
  • Research specific address generation (Segwit?) and create new issues for implementing them
@olemis olemis added bitcoin Bitcoin support firmware MCU firmware stdev wip labels Nov 11, 2019
@olemis olemis added this to the v2 milestone Nov 11, 2019
@olemis
Copy link
Collaborator Author

olemis commented Nov 20, 2019

@stdevAdrianPaez what items are finished . Can you check them out ?

@olemis olemis modified the milestones: v2, v3 Nov 22, 2019
@adriantpaez adriantpaez removed their assignment Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitcoin Bitcoin support firmware MCU firmware stdev wip
Projects
None yet
Development

No branches or pull requests

2 participants