-
Notifications
You must be signed in to change notification settings - Fork 300
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tools, feat: add .github/PULL_REQUEST_TEMPLATE.md (#439)
- Loading branch information
1 parent
1adbf8d
commit ced78b5
Showing
1 changed file
with
20 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
Please fill in this template. | ||
|
||
- [ ] Use a meaningful title for the pull request with prefix '(module|object|source_directory) [bugfix|feat|refactor|]', Such as `db, bugfix: ...`, `tools, feat: ...` | ||
- [ ] Test the change in your own code. (Compile and run.) | ||
- [ ] Add or edit tests to reflect the change. (Run with `fibjs test`.) | ||
- [ ] Ensure commits history clean, merge master/dev and clean meaningless commits by `git rebase`. | ||
|
||
Select type of change you made and delete the others: | ||
|
||
If adding/changing one existing module or internal Object: | ||
- [ ] Add/Change the corresponding `*.idl` file | ||
- [ ] Run `fibjs ./tools/idlc.js` to auto-generate `*.h`, **never change it** | ||
|
||
If removing one existing module or internal Object: | ||
- [ ] Remove corresponding `*.h`, `*.idl`, `*.cpp` | ||
- [ ] Remove all reference to it. | ||
|
||
If adding internal js scripts: | ||
- [ ] Add it to `fibjs/scripts` | ||
- [ ] Run `fibjs ./tools/gen_script.js` |