Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race Condition In ./fsim Tests #39

Closed
ben-krieger opened this issue Dec 16, 2024 · 1 comment · Fixed by #61
Closed

Race Condition In ./fsim Tests #39

ben-krieger opened this issue Dec 16, 2024 · 1 comment · Fixed by #61
Assignees
Labels
bug Something isn't working

Comments

@ben-krieger
Copy link
Member

ben-krieger commented Dec 16, 2024

Nature of the bug

Flaky test due to date printing twice to stdout.

Steps taken to find bug

Detected in CI run: https://github.com/fido-device-onboard/go-fdo/actions/runs/12360006218/job/34493938771

Steps to ensure bug is gone

Run tests for awhile with while go test -v -failfast -count=1 ./fsim; do :; done

Logs

2024-12-16T19:38:56.4293085Z === NAME  TestClientWithCommandModule
2024-12-16T19:38:56.4293484Z     fsim_test.go:296: expected stdout to be integer epoch time, got 
2024-12-16T19:38:56.4293770Z         1734377936
2024-12-16T19:38:56.4293935Z         1734377936
2024-12-16T19:38:56.4294422Z          (err strconv.Atoi: parsing "1734377936\n1734377936": invalid syntax)
@ben-krieger
Copy link
Member Author

Fixed by #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant