Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe there is an error in the loss_indices calculation? #25

Open
Koruvika opened this issue Nov 15, 2024 · 1 comment
Open

Maybe there is an error in the loss_indices calculation? #25

Koruvika opened this issue Nov 15, 2024 · 1 comment

Comments

@Koruvika
Copy link

Koruvika commented Nov 15, 2024

line 152 in trainer_spectre.py
image

In the paper, batch_size equals to 1. With that, loss_indices equals [], is there any mistakes here?

@filby89
Copy link
Owner

filby89 commented Nov 15, 2024

Hey,
if you check https://github.com/filby89/spectre/blob/master/src/trainer_spectre.py#L111 the original batch is 5 D:

1 x T x 3 x H x W

and then we resize it to:

T x 3 x H x W

so these loss indices actually show that the loss applies to all frames in the sequence but the first two and the last two !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants