Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market: avoid loading deal proposals twice during activation #1102

Closed
Tracked by #1020
anorth opened this issue Jan 24, 2023 · 0 comments · Fixed by #1237
Closed
Tracked by #1020

Market: avoid loading deal proposals twice during activation #1102

anorth opened this issue Jan 24, 2023 · 0 comments · Fixed by #1237
Assignees
@alexytsu
Labels
optimisation P3

Comments

@anorth
Copy link
Member

anorth commented Jan 24, 2023

The market actor loads each deal proposal from state twice during activation:

  • once in the call to validate_and_return_deal_space
  • once again at the top level, just after checking it is not already activated

Load the proposals just once and pass them along.
@anorth anorth mentioned this issue Jan 24, 2023
Closed
6 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Network nv19 Feb 24, 2023
@anorth anorth moved this from 📋 Backlog to 🔖 In Scope in Network nv19 Feb 26, 2023
@anorth anorth added the P3 label Feb 26, 2023
@alexytsu alexytsu mentioned this issue Mar 3, 2023
Merged
@anorth anorth moved this from 🔖 In Scope to 👀 In review in Network nv19 Mar 3, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Network nv19 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexytsu alexytsu

Labels
optimisation P3
Projects
No open projects
Network nv19
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load deals once during VerifyDealsForActivation filecoin-project/builtin-actors
2 participants
@anorth @alexytsu