Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases are triggered by code review #1566

Closed
BigLep opened this issue Jul 11, 2024 · 1 comment
Closed

Releases are triggered by code review #1566

BigLep opened this issue Jul 11, 2024 · 1 comment

Comments

@BigLep
Copy link
Member

BigLep commented Jul 11, 2024

Done Criteria

  1. The release steps outlined in https://github.com/filecoin-project/builtin-actors#releasing can be followed without requiring manual clicking in the GitHub UI. Instead, releases should occur as a result of an approved PR.
  2. The release description should be populated with the GitHub-generated release notes.

Why Important

The release process in https://github.com/filecoin-project/builtin-actors#releasing doesn't have any peer review. Mistakes can get made. Mistagging has happened in the past and can't be reverted. This is usually fixed by just doing another release, but this adds unnecessary confusion.

User/Customer

Maintainers

Notes

  1. This is not a standard Rust repo. We don't publish to crates.io.
@BigLep
Copy link
Member Author

BigLep commented Aug 22, 2024

This was closed by #1571

@BigLep BigLep closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

No branches or pull requests

1 participant