Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotus metrics #527

Closed
turuslan opened this issue Nov 18, 2021 · 0 comments
Closed

Lotus metrics #527

turuslan opened this issue Nov 18, 2021 · 0 comments

Comments

@turuslan
Copy link
Contributor

turuslan commented Nov 18, 2021

Add more metrics like lotus/metrics/metrics.go which can be collected by our node.

Our node already has prometheus metrics for counter and gauge. Maybe we need to implement buckets for histogram and summary. Integrating external library may be an option too.

UPD. Didn't find summary metrics usage in lotus yet.

UPD. Switching to prometheus-cpp.

not implemented:

  • info{commit version}
  • peer/count
    • does cpp-libp2p provide disconnect event?
  • *block/failure, *block/success
  • block/validation_ms
    • blocks are not explicitly validated (tipset vm time is other metric vm/applyblocks_total_ms).
    • Validate blocks #539.
  • message/failure, message/success, message/validation_ms
    • messages are not explicitly validated.
  • mpool/getnonce_ms, mpool/getbalance_ms, mpool/addts_ms, mpool/add_ms
    • no corresponding functions or they are trivial.
  • mpool/push_ms
    • api/request_duration_ms {endpoint=MpoolPushMessage} is used instead.
  • block/delay
    • is it for SyncSubmitBlock and/or pubsub?
    • does it have timeout?
  • pubsub/published, pubsub/delivered, pubsub/rejected, pubsub/duplicate, pubsub/recv_rpc, pubsub/send_rpc, pubsub/drop_rpc
    • does cpp-libp2p provide these metrics?
@turuslan turuslan mentioned this issue Nov 24, 2021
@turuslan turuslan assigned turuslan and unassigned turuslan Nov 24, 2021
@zuiris zuiris closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants