Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all built-in Actor itests working with fvm-workbench #44

Open
aarshkshah1992 opened this issue Jan 18, 2024 · 1 comment
Open

Get all built-in Actor itests working with fvm-workbench #44

aarshkshah1992 opened this issue Jan 18, 2024 · 1 comment
Assignees
Milestone

Comments

@aarshkshah1992
Copy link

aarshkshah1992 commented Jan 18, 2024

I was able to use the fvm-workbench to emit the actor events we are interested in by running some of the built-in Actor itests to get gas traces for emitting actors events.

However, not all tests pass with the workbench.

See these PRs for the changes we had to make to ref-fvm & built-in Actors to get green itests.
filecoin-project/ref-fvm#1962 (cloned FVM 4.0 and made these changes)
filecoin-project/builtin-actors#1505

We should do a complete workstream to get all built-in Actor itests green with the fvm-workbench. This will involve debugging and fixing the issues highlighted in the above PRs.

@rvagg
Copy link
Member

rvagg commented Jan 19, 2024

I got a bit lost investigating some of this because I was (separate to your efforts) trying to get this to run just to use it as a learning tool. Some things I learned trying to integrate the current ref-fvm and builtin-actors:

I'm going to stash my changes for now rather than push a branch because it's quite a mess and this feels like quite a rabbit hole that I probably shouldn't entertain right now!

@rvagg rvagg added this to the DX-Streamline milestone May 17, 2024
@rvagg rvagg added this to FilOz May 17, 2024
@rvagg rvagg moved this to 🐱Todo in FilOz May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🐱 Todo
Development

No branches or pull requests

2 participants