Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push channel monitor doesn't stop transfer completes #168

Closed
dirkmc opened this issue Mar 22, 2021 · 1 comment
Closed

push channel monitor doesn't stop transfer completes #168

dirkmc opened this issue Mar 22, 2021 · 1 comment

Comments

@dirkmc
Copy link
Contributor

dirkmc commented Mar 22, 2021

When the data transfer completes, or the deal fails during a data transfer, for example if the provider rejects the transfer, the client's push channel monitor doesn't always stop.

Observed when the provider had an error accepting the deal and the client received "response rejected"

list-transfers shows that the data transfer is in the Failed state, but the channel monitor is still running.

Also observed when a deal completed, the push channel monitor was still logging that it's checking the data rate. It should stop checking the data rate when the transfer completes.

@dirkmc dirkmc changed the title push channel monitor doesn't stop when there's an deal error push channel monitor doesn't stop when there's a deal error Mar 22, 2021
@dirkmc dirkmc changed the title push channel monitor doesn't stop when there's a deal error push channel monitor doesn't stop transfer completes Mar 23, 2021
@dirkmc
Copy link
Contributor Author

dirkmc commented Mar 23, 2021

Fixed by #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant