Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-ipld-prime dependency #202

Open
willscott opened this issue May 9, 2021 · 2 comments
Open

Update go-ipld-prime dependency #202

willscott opened this issue May 9, 2021 · 2 comments

Comments

@willscott
Copy link

This library currently depends on go-ipld-prime v0.5, and due to breaking changes in the interface will not work with versions above v0.7. The current is v0.9.

go-data-transfer@v1.4.3/encoding/encoding.go:30:10: undefined: dagcbor.Encoder
go-data-transfer@v1.4.3/encoding/encoding.go:82:9: undefined: dagcbor.Decoder

For both of these uses of the codec, all that needs to happen is the final r needs to be removed. the functions have become Encode and Decode respectively.

@dirkmc
Copy link
Contributor

dirkmc commented May 12, 2021

Thanks @willscott - is there a pressing need to update go-ipld-prime or is this just a courtesy advisory?

@willscott
Copy link
Author

downstream users of lotus, including https://github.com/filecoin-project/sentinel-visor, https://github.com/filecoin-project/dealbot, https://github.com/filecoin-project/statediff which make use of ipld-prime are limited to v0.7 until this library can be migrated to the newer interface.

There aren't immediate features any of them need from v0.9, so just a courtesy advisory at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants