Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error properly when graphsync request's context is cancelled #207

Open
jennijuju opened this issue May 18, 2021 · 1 comment
Open

Comments

@jennijuju
Copy link
Member

handle https://github.com/filecoin-project/go-data-transfer/blob/master/transport/graphsync/graphsync.go#L185-L191 properly

this might be the cause for filecoin-project/lotus#6273 where the client-side is not getting the Complete message back from the miner

@dirkmc
Copy link
Contributor

dirkmc commented May 18, 2021

The underlying cause actually seems to be a bug in graphsync, as described in the comment:

// TODO: There seems to be a bug in graphsync. I believe it should return
// graphsync.RequestCancelledErr on the errChan if the request's context is
// cancelled, but it doesn't seem to be doing that

So I believe the fix would actually need to be made in go-graphsync.

However for now the code works around the bug.

this might be the cause for filecoin-project/lotus#6273 where the client-side is not getting the Complete message back from the miner

I think filecoin-project/lotus#6273 is actually probably unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants