Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieval checkForActiveDeal is too aggressive #753

Closed
magik6k opened this issue Sep 28, 2022 · 2 comments · Fixed by #764
Closed

Retrieval checkForActiveDeal is too aggressive #753

magik6k opened this issue Sep 28, 2022 · 2 comments · Fixed by #764

Comments

@magik6k
Copy link
Collaborator

magik6k commented Sep 28, 2022

I'm not sure why exactly we want to stop duplicate retrievals for the same piece, but checkForActiveDeal should at least permit retrievals for the same piece with different selectors.

Being able to only do a single retrieval per piece in parallel severely limits tools like filecoin-project/lotus#9382.

@dirkmc
Copy link
Contributor

dirkmc commented Sep 29, 2022

Looks like it was implemented as a requirement of filecoin-project/lotus#5443

I agree though, there's not really a good reason to prevent multiple concurrent deals.

@hannahhoward
Copy link
Collaborator

honestly yall can do whatever you want. go-fil-markets retrieval client is ONLY used by Lotus. It should probably move directly into the Lotus repo.

everybody else uses FilClient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants