Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant reads and writes #68

Closed
austinabell opened this issue Oct 7, 2020 · 2 comments
Closed

Redundant reads and writes #68

austinabell opened this issue Oct 7, 2020 · 2 comments
Assignees
Labels
need/triage Needs initial labeling and prioritization

Comments

@austinabell
Copy link

The issue is around the fact that a shard is persisted when a hamt is expanded here and also the cache is flushed and cleared even on read only access which leads to completely unnecessary writes.

I'll link to the PR where I add these extra writes/cache clears as I think it might be the easiest way to describe the diff and what can be improved: ChainSafe/forest#731. The functionality that matches this repo currently is under the go-interop feature and can ignore the Amt changes (I grouped this change together)

I haven't benchmarked the difference in a real use case, but generally saw the writes and reads to be between 1.5-2x more than they need to be.

@austinabell austinabell added the need/triage Needs initial labeling and prioritization label Oct 7, 2020
@rvagg
Copy link
Member

rvagg commented Oct 7, 2020

Eric did some further investigation and documentation work on this here too: #61

@ZenGround0 ZenGround0 self-assigned this Nov 2, 2020
@Stebalien
Copy link
Member

This will be fixed in #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

4 participants