Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API docs #205

Closed
jennijuju opened this issue Oct 22, 2020 · 4 comments
Closed

Improve API docs #205

jennijuju opened this issue Oct 22, 2020 · 4 comments
Labels
dif/expert Extensive knowledge (implications, ramifications) required effort/weeks Estimated to take multiple weeks kind/enhancement P2 Medium: Good to have, but can wait until someone steps up

Comments

@jennijuju
Copy link
Member

Well, we know what this is about 😀 The docgen generated api docs is not good enough, we want something that shows real request examples and responses, and comments on what does the fields mean.

@jennijuju
Copy link
Member Author

one option is to have it in postman

@dineshshenoy
Copy link

Potentially swagger is a good option here?

@jennijuju
Copy link
Member Author

@magik6k and @whyrusleeping suggested that we can add more stuff to docsgen:

  • More real/mae-sense data to generate example
  • run it against the node and generates sample output
  • generate curl example

@dineshshenoy
Copy link

Maybe we can breakup this task into three components:

  1. Using swagger or a related docs framework to define the schema and generate a swagger.json file (infrastructure)
  2. Add annotations to our existing docs to match with the schema for Initial structure lotus#1 - the more tedious aspect
  3. Add a rich UI layer from the swagger.json (lots of potential like readthedocs.io, RST, Postman, etc)

@jennijuju jennijuju changed the title [Attention needed] API docs API docs Nov 17, 2020
@jennijuju jennijuju changed the title API docs API docs improvements Nov 17, 2020
@jennijuju jennijuju changed the title API docs improvements Improve API docs Nov 17, 2020
@jennijuju jennijuju transferred this issue from filecoin-project/lotus Apr 7, 2021
@johnnymatthews johnnymatthews added project/lotus dif/expert Extensive knowledge (implications, ramifications) required effort/weeks Estimated to take multiple weeks kind/enhancement P2 Medium: Good to have, but can wait until someone steps up labels Sep 2, 2021
@johnnymatthews johnnymatthews transferred this issue from filecoin-project/filecoin-docs May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/expert Extensive knowledge (implications, ramifications) required effort/weeks Estimated to take multiple weeks kind/enhancement P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

3 participants