-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mpool] data race when adding messages #10755
Comments
Nevermind. We still need |
|
So, we have a couple of options. Either:
For 2, we'd just replace lotus/chain/messagepool/messagepool.go Line 877 in 28d0274
GetActorBefore and remove all the logic around "warming the cache" in general.
|
Sounds good! I opened a PR for 2): #10758 |
Turns out this isn't actually an issue. |
We're calling
mp.getStateNonce
without holding the lock:lotus/chain/messagepool/messagepool.go
Line 773 in 28d0274
This used to be safe, but this method now resolves addresses which can't be done without holding the lock. We should probably just remove this call (
mp.getStateNonce
) entirely.We may also be able to get rid of this "warm the cache" logic entirely. We still have a few more instances of
GetActorAfter
, but I think we can drop those.The text was updated successfully, but these errors were encountered: