-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record processed epochs / tipsets in events index #11640
Comments
Specifically, we need to record every tipset (tipset key) we've processed, and the tipset's height (really, we just need the tipset key, but having the height is likely useful for querying). When querying for events, we'd be able to distinguish between "no events" and "haven't processed this tipset" by checking if the tipset key is in the database. This will also let us fix #11007 by:
|
In terms of the migration... I believe that checking if we have any events at a tipset is relatively inexpensive, and we only need to do that for tipsets that don't have recorded events. |
@Stebalien iirc we want this for the message index too, is that right (when we were discussing tracing api)? |
Yes. |
@rvagg please feel free to assign me other issues that relate to this, considering the need for migration. That should reduce the need for coordination. Thanks |
Arising out of #11618 - Lotus currently has no way to know whether the earliest events it has are the earliest there are or the earliest that that have been recorded. Ideally requesting "events from height X" should error if we can say for sure "I don't have events for that height", but that's not possible today because we don't know.
GetActorEvents
andSubscribeActorEvents
APIs if you request a height that's earlier than we have.The text was updated successfully, but these errors were encountered: