Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "clock" #11677

Open
Stebalien opened this issue Mar 5, 2024 · 1 comment
Open

Update "clock" #11677

Stebalien opened this issue Mar 5, 2024 · 1 comment
Assignees

Comments

@Stebalien
Copy link
Member

We use a raul's fork of the mock clock library. Unfortunately, raul's fork is out of date and upstream is unmaintained. We either need to update the fork, or switch to usptream.

IMO, we should just switch to upstream. It "works" and doesn't appear to need any real changes. That would match libp2p (which uses upstream now).

@rvagg
Copy link
Member

rvagg commented Mar 5, 2024

I looked in to this last year for lassie and while the current clock library is OK, it's not perfect, but https://github.com/itbasis/go-clock might be a viable alternative. It's the fork with the most attention so far and seems to be maintained. I know libp2p uses this a bit, maybe they have an alternative. @sukunrt do you have an alternative approach yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants