Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miner: provide full message on log output when simulateMsgGas fails #11836

Closed
rvagg opened this issue Apr 5, 2024 · 0 comments · Fixed by #11840
Closed

Miner: provide full message on log output when simulateMsgGas fails #11836

rvagg opened this issue Apr 5, 2024 · 0 comments · Fixed by #11840
Assignees

Comments

@rvagg
Copy link
Member

rvagg commented Apr 5, 2024

There are 3 calls to simulateMsgGas, which does a GasEstimateMessageGas, two in storage/pipeline/commit_batch.go and one in storage/pipeline/precommit_batch.go. The two in commit_batch.go have a log.Errorf that provides the hex of the cbor encoded params. The one in precommit_batch.go skips the log.

Unfortunately, the params aren't quite enough to be able to re-execute the message to see the error. If the log is moved into simulateMsgGas then the full encoded message could be printed which could then be run with lotus-shed msg <hex>. The command itself could even be put into the log output to just make it a copy-paste exercise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging a pull request may close this issue.

2 participants