Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX Streamline] Remove Lotus Client deal making CLI and API #12002

Closed
4 of 9 tasks
aarshkshah1992 opened this issue May 16, 2024 · 1 comment · Fixed by #11999
Closed
4 of 9 tasks

[DX Streamline] Remove Lotus Client deal making CLI and API #12002

aarshkshah1992 opened this issue May 16, 2024 · 1 comment · Fixed by #11999
Assignees
Labels
kind/feature Kind: Feature
Milestone

Comments

@aarshkshah1992
Copy link
Contributor

Checklist

  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated feature request to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

go-fil-markets has been deprecated for a long time. This PR aims to remove the Lotus Client deal making CLI and API as we don't need any of that code anymore.

Describe the solution you'd like

go-fil-markets has been deprecated for a long time. This PR aims to remove the Lotus Client deal making CLI and API as we don't need any of that code anymore.

Describe alternatives you've considered

No response

Additional context

No response

@aarshkshah1992 aarshkshah1992 added the kind/feature Kind: Feature label May 16, 2024
@aarshkshah1992 aarshkshah1992 self-assigned this May 16, 2024
@rvagg rvagg changed the title Remove Lotus Client deal making CLI and API [DX Streamline] Remove Lotus Client deal making CLI and API May 17, 2024
@rvagg rvagg added this to the DX-Streamline milestone May 17, 2024
@rvagg
Copy link
Member

rvagg commented May 17, 2024

Some notes I was writing at #12008 before I realised this issue existed:

  • Particular focus on what is currently provided by Boost today.
  • Possibly moving some functionality into lotus-shed for convenience.
  • Taking careful note of builtin actors testing that will be removed in the process so we can restore some kind of coverage via alternate means.
  • Clear documentation of what's changing for downstream users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Kind: Feature
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging a pull request may close this issue.

2 participants