Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lotus-miner retrieval add-file command #2875

Closed
whyrusleeping opened this issue Aug 6, 2020 · 5 comments
Closed

Add a lotus-miner retrieval add-file command #2875

whyrusleeping opened this issue Aug 6, 2020 · 5 comments

Comments

@whyrusleeping
Copy link
Member

In order to allow the retrieval market to bloom beyond the storage market, retrieval miners need to be able to serve arbitrary content.

We should add a command/api that allows retrieval miners to make given data available to their clients, registering it in their local piecestore, and making it available for serving to others in the network. The data should be backed by a blockstore, either a local one or an ipfs backed one.

@mikeal
Copy link

mikeal commented Aug 6, 2020

If you’re using an IPFS backed store you could make it lotus-miner retrieval {CID} and just pull the data out of the network into the local store. This would allow for a lot more than just individual files to be added.

@whyrusleeping
Copy link
Member Author

@mikeal Yeah, I think that approach makes sense. I'm just being initially somewhat hesitant, and opting for an 'allowlist' of content as the default.

@aschmahmann
Copy link
Contributor

aschmahmann commented Aug 6, 2020

I'm not very familiar with how the IPFS backed datastore works with Lotus, but I'm a little confused as to how/why a retrieval miner would use go-ipfs.

go-ipfs does not currently make it very easy to restrict the flow of information in your blockstore and instead makes it really easy for anyone one the network to get data from you. Since retrieval miner's presumably want to get paid for sending data instead of just sending it for free they almost certainly are not going to want to store their data in go-ipfs.

If you end up implementing some access control blockstore I'm sure go-ipfs would take a look at it though 😄

@mikeal
Copy link

mikeal commented Aug 7, 2020

I’m thinking about this from a user perspective, which isn’t entirely congruent with the implementation.

There’s already a command that allows you to store any CID from the IPFS network. I’m imagining a command that, to the user, is very similar. The actual implementation is probably going to be quite different, since the client doesn’t need to permanently store and make available in IPFS the data it pulls in for a storage deal in the way this retrieval miner would need to do. This is all to say that this command would not necessary leverage any existing pattern of IPFS usage in Lotus if it decides to take on this feature.

@rjan90 rjan90 added the kind/feature Kind: Feature label Aug 30, 2022
@rjan90 rjan90 added this to the LM-Tech-Debt-Legacy-Markets milestone Mar 24, 2023
@rjan90
Copy link
Contributor

rjan90 commented Jun 3, 2024

Closing this ticket as the Legacy Lotus/Lotus-Miner Markets sub-system reached EOL at the end of the 31st January 2023, and is being completely removed from the code here:

@rjan90 rjan90 closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👀 In Review
Development

No branches or pull requests

4 participants