Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restarting the data transfer increases bytes transfered with no network traffic #5225

Closed
xinaxu opened this issue Dec 19, 2020 · 2 comments
Closed
Labels
area/markets Area: Markets kind/bug Kind: Bug

Comments

@xinaxu
Copy link

xinaxu commented Dec 19, 2020

Describe the bug
First, there have a been a few bug reports related to data transfer stuck so I'm not repeating that here. The issue my miner experienced is when I restart the data transfer using lotus-miner data-transfers restart XXX. The number of bytes transfered will increase however there is no network activity.

To Reproduce
Steps to reproduce the behavior:
Assume there is a data transfer channel for storage deals that has transfered 321MiB and stuck.

  1. lotus-miner data-transfers restart XXX where XXX is the channel ID listed in lotus-miner data-transfers list
  2. Run watch lotus-miner data-transfers list, the bytes transfered for restarted channel will keep increasing till 642MiB and stuck again
  3. Meanwhile, use nload to monitor network usage shows no obvious traffic increase while the bytes transfered keep increasing
  4. Repeat and observe the data transfer channel start again and stuck at 321MiB * N. The value can keep increasing far beyond the piece size.

Expected behavior
Either the data transfer should begin with real network traffic, or the data transfered should not increase.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Version (run lotus version):
lotus version 1.3.0+git.19d457ae5.dirty

Additional context
https://filecoinproject.slack.com/archives/C01AZP8BKRQ/p1608309045337100?thread_ts=1608251272.292100&cid=C01AZP8BKRQ
@dineshshenoy

@xinaxu xinaxu changed the title Confusing behavior when restarting the data transfer Restarting the data transfer increases bytes transfered with no network traffic Dec 19, 2020
@dirkmc
Copy link
Contributor

dirkmc commented Jan 5, 2021

Thank you for the bug report.

I think the underlying cause is that on restart we are double-counting sent / received blocks in the data transfer layer. I've opened an issue here: ipfs/go-graphsync#141

@dirkmc dirkmc added area/markets Area: Markets kind/bug Kind: Bug labels Jan 5, 2021
@dineshshenoy
Copy link

Closing since being tracked in graphsync#141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/markets Area: Markets kind/bug Kind: Bug
Projects
None yet
Development

No branches or pull requests

3 participants