fix: fix address network override via env var #12590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default address.CurrentNetwork was changed to mainnet. As a result if `LOTUS_USE_TEST_ADDRESSES` is set we need to explicitly use testnet address.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
masih
changed the title
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
|
I don't know if |
Stebalien
approved these changes
Oct 11, 2024
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
Default address.CurrentNetwork was changed to mainnet. As a result if `LOTUS_USE_TEST_ADDRESSES` is set we need to explicitly use testnet address.
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
Default address.CurrentNetwork was changed to mainnet. As a result if `LOTUS_USE_TEST_ADDRESSES` is set we need to explicitly use testnet address.
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
Default address.CurrentNetwork was changed to mainnet. As a result if `LOTUS_USE_TEST_ADDRESSES` is set we need to explicitly use testnet address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Default address.CurrentNetwork was changed to mainnet. As a result if
LOTUS_USE_TEST_ADDRESSESis set we need to explicitly use testnet address.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: