Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISS: Add snapshot hash to checkpoints #12

Merged
merged 7 commits into from
Apr 26, 2022
Merged

ISS: Add snapshot hash to checkpoints #12

merged 7 commits into from
Apr 26, 2022

Conversation

sergefdrv
Copy link
Contributor

@sergefdrv sergefdrv commented Apr 20, 2022 •
edited
Loading

Relates to #9

matejpavlovic
matejpavlovic approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd have written it the same way.

@sergefdrv
Copy link
Contributor Author

Summary of changes: added comments

@matejpavlovic matejpavlovic marked this pull request as ready for review April 22, 2022 15:57
@matejpavlovic matejpavlovic marked this pull request as draft April 22, 2022 16:17
matejpavlovic
matejpavlovic approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sergey Fedorov added 5 commits April 25, 2022 10:44
Regenerate Protobuf code according to Readme
5e153d8 
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
ISS: Compute and save app snapshot hash when creating checkpoints
112e451 
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
ISS: Augment PersistCheckpointEvent with app snapshot hash
ee2ab1e 
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
ISS: Augment CheckpointMessage with app snapshot hash
bb1ec1b 
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
ISS: Augment StableCheckpoint with app snapshot hash
b2af9aa 
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
sergefdrv
sergefdrv commented Apr 25, 2022
View reviewed changes
pkg/iss/checkpoint.go Outdated Show resolved Hide resolved
@sergefdrv
Copy link
Contributor Author

Summary of changes: rebase with conflict resolution

Sergey Fedorov added 2 commits April 25, 2022 14:27
ISS: Add diagnostic logger to checkpoint tracker
fdc9d7c 
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
ISS: Verify app snapshot hash in received Checkpoint messages
66512fc 
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
@sergefdrv
Copy link
Contributor Author

Summary of changes: added diagnostic output on mismatching app snapshot hash

@sergefdrv sergefdrv marked this pull request as ready for review April 25, 2022 12:29
@matejpavlovic matejpavlovic mentioned this pull request Apr 25, 2022
Closed
matejpavlovic
matejpavlovic approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@matejpavlovic matejpavlovic merged commit bde1e63 into consensus-shipyard:main Apr 26, 2022
@sergefdrv sergefdrv deleted the checkpoint-hash branch April 26, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejpavlovic matejpavlovic matejpavlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergefdrv @matejpavlovic