Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mir network transport #155

Merged
merged 13 commits into from
Jul 27, 2022
Merged

Update Mir network transport #155

merged 13 commits into from
Jul 27, 2022

Conversation

dnkolegov
Copy link
Contributor

This PR makes several changes in network transport to support reconfiguration in Eudico.

matejpavlovic
matejpavlovic approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I like the idea of only using the Connect method to update the connections.
Could you also add a way of closing the connections that are not part of the new membership?

pkg/net/libp2p/libp2ptransport.go Outdated Show resolved Hide resolved
@dnkolegov
Copy link
Contributor Author

Could you also add a way of closing the connections that are not part of the new membership?

@matejpavlovic I have added a CloseOldConnections method.

matejpavlovic
matejpavlovic approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dnkolegov dnkolegov merged commit 97ade87 into main Jul 27, 2022
@dnkolegov dnkolegov deleted the mir-transport-draft branch July 27, 2022 12:43
@matejpavlovic matejpavlovic mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejpavlovic matejpavlovic matejpavlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnkolegov @matejpavlovic