Make Init event optional in DSL modules #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most modules don't need to do anything on Init and the philosophy of DSL modules is to avoid mixing protocol logic with boilerplate. Hence, it makes sense to avoid writing an empty handler for init for each DSL module and just make processing this event optional.
|
Will merge without a review. |
xosmig
added a commit
to xosmig/mir
that referenced
this pull request
Aug 4, 2022
Handling the Init event is optional for dsl modules since consensus-shipyard#166.
xosmig
added a commit
to xosmig/mir
that referenced
this pull request
Aug 4, 2022
Handling the Init event is optional for dsl modules since consensus-shipyard#166.
xosmig
added a commit
that referenced
this pull request
Aug 4, 2022
Handling the Init event is optional for dsl modules since #166.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most modules don't need to do anything on Init and the philosophy
of DSL modules is to avoid mixing protocol logic with boilerplate.
Hence, it makes sense to avoid writing an empty handler for init
for each DSL module and just make processing this event optional.