-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch fetcher #201
Merged
matejpavlovic
merged 5 commits into
consensus-shipyard:main
from
matejpavlovic:batch-fetcher
Aug 31, 2022
Merged
Batch fetcher #201
matejpavlovic
merged 5 commits into
consensus-shipyard:main
from
matejpavlovic:batch-fetcher
Aug 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejpavlovic
force-pushed
the
batch-fetcher
branch
from
August 26, 2022 09:39
af1ac76
to
482b3f9
Compare
Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
matejpavlovic
force-pushed
the
batch-fetcher
branch
from
August 29, 2022 14:53
482b3f9
to
8f5ba09
Compare
Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
xosmig
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a few minor comments (mostly cosmetic).
xosmig
reviewed
Aug 31, 2022
Signed-off-by: Matej Pavlovic <matopavlovic@gmail.com>
matejpavlovic
force-pushed
the
batch-fetcher
branch
from
August 31, 2022 14:23
60250c4
to
0fbb21a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module for transforming availability certificates into batches of requests