Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISS: Collect garbage state #52

Merged
merged 6 commits into from
May 13, 2022

Conversation

sergefdrv
Copy link
Contributor

@sergefdrv sergefdrv commented May 5, 2022

This PR aims at resolving #10

@sergefdrv sergefdrv changed the title Garbage collection ISS: Collect garbage state May 9, 2022
@sergefdrv sergefdrv force-pushed the garbage-collection branch 4 times, most recently from 1239732 to 6260ec8 Compare May 11, 2022 13:15
@sergefdrv sergefdrv marked this pull request as ready for review May 11, 2022 13:16
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👍 :)

pkg/iss/iss.go Show resolved Hide resolved
pkg/iss/iss.go Show resolved Hide resolved
Sergey Fedorov added 6 commits May 13, 2022 13:20
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
ISS creates at most one checkpoint per epoch capturing the initial
state of the epoch. In order to simplify garbage collection, identify
checkpoints by the epoch number and maintain checkpoint sub-protocol
state as part of epoch state.

Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
@sergefdrv sergefdrv merged commit f3f48c0 into consensus-shipyard:main May 13, 2022
@sergefdrv sergefdrv deleted the garbage-collection branch May 16, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants