-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISS: Collect garbage state #52
Merged
sergefdrv
merged 6 commits into
consensus-shipyard:main
from
sergefdrv:garbage-collection
May 13, 2022
Merged
ISS: Collect garbage state #52
sergefdrv
merged 6 commits into
consensus-shipyard:main
from
sergefdrv:garbage-collection
May 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergefdrv
force-pushed
the
garbage-collection
branch
from
May 5, 2022 21:19
987e6dc
to
d3fb3b9
Compare
sergefdrv
force-pushed
the
garbage-collection
branch
4 times, most recently
from
May 11, 2022 13:15
1239732
to
6260ec8
Compare
matejpavlovic
approved these changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful 👍 :)
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
ISS creates at most one checkpoint per epoch capturing the initial state of the epoch. In order to simplify garbage collection, identify checkpoints by the epoch number and maintain checkpoint sub-protocol state as part of epoch state. Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
sergefdrv
force-pushed
the
garbage-collection
branch
from
May 13, 2022 11:20
6260ec8
to
1030a15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at resolving #10