Fix transitioning into new epoch #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2022 11:49
Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
This makes at least one of the integration test to order requests across more than one epoch. Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
sergefdrv
force-pushed
the
epoch-transition-fix
branch
from
5483dac
to
7723c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug introduced in c01d2e8 which broke
ISS.epochFinishedand resolves #2. It also adjusts the default ISS configuration such that there is at least one integration test that has to order requests across multiple epochs.