Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

CI integration in filecoin-project/lotus #223

Closed
raulk opened this issue Aug 11, 2020 · 1 comment
Closed

CI integration in filecoin-project/lotus #223

raulk opened this issue Aug 11, 2020 · 1 comment
Labels
workstream/vm-conformance-tests Workstream: VM Conformance Tests

Comments

@raulk
Copy link
Member

raulk commented Aug 11, 2020

Once we have #221 and #222, we should set up a Circle CI job in filecoin-project/lotus that does the following:

  1. Does a shallow clone of the filecoin/vm-tests repo.
    • Lock in a concrete tag/branch/commit in a .vmtests.toml config file at the root of the repo.
    • This has many benefits:
      • Explicitly declares which version of the corpus this VM implementation complies with.
      • Future-proof: allows us to conduct change management / evolution cleanly without incurring in false, noisy breakage. Removes volatility.
  2. Exercises the Lotus VM against the test vectors using the test driver.
  3. Populate a JUnit XML file via gotestsum so CircleCI can populate the Tests tab.
@raulk raulk added the workstream/vm-conformance-tests Workstream: VM Conformance Tests label Aug 11, 2020
@raulk
Copy link
Member Author

raulk commented Aug 18, 2020

This is in review on lotus side: filecoin-project/lotus#3081

@raulk raulk closed this as completed Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workstream/vm-conformance-tests Workstream: VM Conformance Tests
Projects
None yet
Development

No branches or pull requests

1 participant