Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation for Buffer shim #769

Closed
bcheidemann opened this issue Mar 20, 2021 · 2 comments
Closed

Incorrect documentation for Buffer shim #769

bcheidemann opened this issue Mar 20, 2021 · 2 comments

Comments

@bcheidemann
Copy link
Contributor

Using the example webpack config results in the Buffer being resolved incorrectly. Webpack resolves Buffer globally to:
{ __esModule: true, default: ... , Buffer: ... }

Fixed by #768

@humphd
Copy link
Contributor

humphd commented Mar 20, 2021

If you use Fixes #768 in your PR description, it will auto-close these.

@humphd humphd closed this as completed Mar 20, 2021
@bcheidemann
Copy link
Contributor Author

Thanks, will do this in future 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants