Skip to content

Conversation

@Youssef1313
Copy link

@Youssef1313 Youssef1313 commented Dec 21, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Looking at the test run in CI confirming that all tests are still running as before. (Still waiting for workflows to be approved to run)

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the global.json, LGTM

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Dec 21, 2025
Signed-off-by: Youssef Victor <youssefvictor00@gmail.com>
@hez2010
Copy link
Member

hez2010 commented Dec 22, 2025

Looks fine to me. Thank you!

yaira2
yaira2 previously approved these changes Dec 22, 2025
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Dec 22, 2025
Signed-off-by: Yair <39923744+yaira2@users.noreply.github.com>
Comment on lines +240 to +241
--test-modules $env:AUTOMATED_TESTS_ASSEMBLY_DIR\**\Files.InteractionTests.dll `
--results-directory $env:AUTOMATED_TESTS_ASSEMBLY_DIR `
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The test command in the CI workflow uses a glob pattern that looks for a .dll, but the build now produces an .exe, which will cause tests to fail.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The CI workflow command dotnet test --test-modules $env:AUTOMATED_TESTS_ASSEMBLY_DIR\**\Files.InteractionTests.dll will fail. The project Files.InteractionTests.csproj has been changed to produce an executable (<OutputType>Exe</OutputType>), resulting in a Files.InteractionTests.exe file. The glob pattern in the test command explicitly searches for a .dll file, which will not match the .exe output. Consequently, the test runner will not find any test modules to execute, causing the test job to fail.

💡 Suggested Fix

Update the glob pattern in the dotnet test command to search for the .exe file instead of the .dll. Change --test-modules $env:AUTOMATED_TESTS_ASSEMBLY_DIR\**\Files.InteractionTests.dll to --test-modules $env:AUTOMATED_TESTS_ASSEMBLY_DIR\**\Files.InteractionTests.exe.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/ci.yml#L240-L241

Potential issue: The CI workflow command `dotnet test --test-modules
$env:AUTOMATED_TESTS_ASSEMBLY_DIR\**\Files.InteractionTests.dll` will fail. The project
`Files.InteractionTests.csproj` has been changed to produce an executable
(`<OutputType>Exe</OutputType>`), resulting in a `Files.InteractionTests.exe` file. The
glob pattern in the test command explicitly searches for a `.dll` file, which will not
match the `.exe` output. Consequently, the test runner will not find any test modules to
execute, causing the test job to fail.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8199804

@yaira2
Copy link
Member

yaira2 commented Jan 6, 2026

@Youssef1313 it looks like the ci pipeline is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Quality: Migrate tests from VSTest to Microsoft.Testing.Platform

5 participants