-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Code Quality: Migrate from VSTest to Microsoft.Testing.Platform #17982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
marcelwgn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the global.json, LGTM
Signed-off-by: Youssef Victor <youssefvictor00@gmail.com>
|
Looks fine to me. Thank you! |
Signed-off-by: Yair <39923744+yaira2@users.noreply.github.com>
| --test-modules $env:AUTOMATED_TESTS_ASSEMBLY_DIR\**\Files.InteractionTests.dll ` | ||
| --results-directory $env:AUTOMATED_TESTS_ASSEMBLY_DIR ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The test command in the CI workflow uses a glob pattern that looks for a .dll, but the build now produces an .exe, which will cause tests to fail.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The CI workflow command dotnet test --test-modules $env:AUTOMATED_TESTS_ASSEMBLY_DIR\**\Files.InteractionTests.dll will fail. The project Files.InteractionTests.csproj has been changed to produce an executable (<OutputType>Exe</OutputType>), resulting in a Files.InteractionTests.exe file. The glob pattern in the test command explicitly searches for a .dll file, which will not match the .exe output. Consequently, the test runner will not find any test modules to execute, causing the test job to fail.
💡 Suggested Fix
Update the glob pattern in the dotnet test command to search for the .exe file instead of the .dll. Change --test-modules $env:AUTOMATED_TESTS_ASSEMBLY_DIR\**\Files.InteractionTests.dll to --test-modules $env:AUTOMATED_TESTS_ASSEMBLY_DIR\**\Files.InteractionTests.exe.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/ci.yml#L240-L241
Potential issue: The CI workflow command `dotnet test --test-modules
$env:AUTOMATED_TESTS_ASSEMBLY_DIR\**\Files.InteractionTests.dll` will fail. The project
`Files.InteractionTests.csproj` has been changed to produce an executable
(`<OutputType>Exe</OutputType>`), resulting in a `Files.InteractionTests.exe` file. The
glob pattern in the test command explicitly searches for a `.dll` file, which will not
match the `.exe` output. Consequently, the test runner will not find any test modules to
execute, causing the test job to fail.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8199804
|
@Youssef1313 it looks like the ci pipeline is failing. |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.