Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wildcards in "Domains always allowed" #328

Closed
raleik-pl opened this issue Apr 25, 2023 · 1 comment
Closed

Allow wildcards in "Domains always allowed" #328

raleik-pl opened this issue Apr 25, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@raleik-pl
Copy link

Problem Description

I want to have a pwa window for e.g. all google apps. Right now I need to specify all the domains, like this:
mail.google.com,calendar.google.com,drive.google.com,accounts.google.com,meet.google.com,docs.google.com,myaccount.google.com,contacts.google.com,keep.google.com
This list is not complete, i.e. there are domains that google apps jump to for authentication etc,

Proposed Solution

I'd like a possibility to specify allowed domain with a wildcard, like this
*.google.com

Additional Information

n/a

@raleik-pl raleik-pl added the enhancement New feature or request label Apr 25, 2023
@filips123 filips123 moved this to To Do in PWAsForFirefox Apr 28, 2023
@filips123 filips123 added this to the 2.6.0 milestone May 1, 2023
@filips123 filips123 modified the milestones: 2.6.0, 2.7.0 May 18, 2023
@filips123 filips123 moved this from To Do to In Progress in PWAsForFirefox Jul 2, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in PWAsForFirefox Jul 7, 2023
@filips123
Copy link
Owner

This will be added in the next release. Also, due to how wildcard matching works here, to match domains such as mail.google.com, calendar.google.com etc. and google.com, you will also need to include google.com domains separately (like *.google.com,google.com).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants