Pinned webpage causes issue

[Roterfux]

I tried to create a pwa for Outlook.com, and I had the tab pinned.
If you try to create a PWA then, it causes "An unexpected error occurred".
It's hard to see if there is an error in the console, since it's flooded with errors from Outlook itself.

fyi: It works, if the tab is not pinned.

[filips123]

Does it work with other websites if they are pinned, and does it work with Outlook.com if it's not pinned? Because I've tested this with other websites and they work fine even if pinned, but when I tested it with Outlook.com, it didn't work even when it was unpinned.

I've checked the manifest for Outlook.com, and it seems it has malformed icon URLs (at least for some non-English variants), which PWAsForFirefox cannot process:

This seems to be a problem with Outlook.com. However, I'll also try to improve error handling in cases of malformed URLs.

[Roterfux]

It does work for me, if Outlook.com is NOT pinned. (I do use it like this)

For testing, I tried to use https://roadmap.sh/ and https://dev.azure.com/ - both work pinned as well.

[filips123]

Please create a DEBUG file as described here. Then, try to install Outlook.com when pinned and upload firefoxpwa.log, firefoxpwa-stdout.log and firefoxpwa-stderr.log.

[Roterfux]

Sorry for the late answer:

firefoxpwa-stderr.log
firefoxpwa-stdout.log
firefoxpwa.log

Console log:
Fehler beim Verarbeiten des Wertes für 'white-space'. Deklaration ignoriert. 2 manage.html GET https://duerr5.bnapp02.kwp-online.de/relay/duerr5/pwa/bnapp/assets/icons/icon-72x72.png [HTTP/3 200 OK 0ms] GET https://ssl.gstatic.com/docs/spreadsheets/favicon3.ico [HTTP/3 200 OK 0ms] GET https://statics.teams.cdn.office.net/hashed/favicon/prod/favicon-f1722d9.ico [HTTP/2 200 OK 0ms] Fehler beim Verarbeiten des Wertes für 'white-space'. Deklaration ignoriert. 2 install.html XHRGET https://outlook.office.com/mail/manifests/pwa.json?culture=de [HTTP/3 200 OK 73ms] Uncaught (in promise) Error: An unexpected error occurred undefined

Uncaught (in promise) Error: An unexpected error occurred undefined onclick moz-extension://6ddcc6d9-3c6d-4ccc-99cb-05932951cbfc/sites/install.bf5555d0.js:1 AsyncFunctionThrow self-hosted:760 (Async: async) <anonym> moz-extension://6ddcc6d9-3c6d-4ccc-99cb-05932951cbfc/sites/install.bf5555d0.js:1 AsyncFunctionNext self-hosted:756 (Async: async) <anonym> moz-extension://6ddcc6d9-3c6d-4ccc-99cb-05932951cbfc/sites/install.bf5555d0.js:1

[filips123]

It seems to be the same issue as I'm having (with broken URLs), but I don't know why it only happens to you when the tab is pinned. So, I guess you can just unpin it, install the PWA and pin it again? Alternatively, you can uncheck "use the manifest" when installing the PWA (although this will mean menu entry shortcuts and few other similar features won't work).

The actual issue with invalid URLs that cause panic is because of a library that has this bug (seanmonstar/reqwest#668, seanmonstar/reqwest#1399). I probably cannot fix this myself.

[Roterfux]

That is how I did it. Unpin, install and pin again (or used the installed version) as a workaround.
Just noticed that issue as a weird behaviour

[filips123]

Perhaps Outlook.com is doing some testing by serving different manifests, and one of them is corrupted.

So, as this seems to be an issue with website and library (reqwest) that I cannot fix, I'll close this issue. Probably Microsoft will fix at some point, and I also hope reqwest fill fix that bug in the future.

I may also add this to the documentation when I finish it.

[Roterfux]

Ok