Out of scope links no longer open in default browser

[acorazza]

Description

I use a PWA for Fastmail. Until today, clicking an out-of-scope link opened the link in Firefox. Now I get a system dialog that says "open the https link with Firefox?" and nothing happens when clicking the "open link" button.

Steps to Reproduce

1. Set out of scope links to open in browser
2. Click out of scope link
3. Click "open link"

Environment

• Operating system: EndeavourOS / Arch Linux
• System architecture: x86
• Desktop environment: KDE Plasma 6
• Installation method: Firefox Nightly tar
• PWAsForFirefox extension version: 2.13.3
• PWAsForFirefox native version: Not sure where to find this
• PWAsForFirefox runtime version: 2.14.0
• Firefox version: 137.0a1

[filips123]

I can reproduce that a dialog is opened and will fix that, but for me, clicking on "open link" still works fine. Please try to get the runtime logs when you click on that button. Also, check in the settings of the app browser that Firefox is set as a handler for HTTP(s) links:

[acorazza]

I should have mentioned this in my first post, but thank you for your work on this plugin, it's incredibly helpful!

The HTTPS thing fixed it; it was set to "Firefox", not "Firefox Nightly". I'm not sure why it stopped working out of nowhere, but the dialog box now works.

This is the console output of the runtime log:

Uncaught TypeError: this._button is null
init chrome://browser/content/browser-addons.js:1663
onDOMContentLoaded chrome://browser/content/browser-init.js:222

init chrome://browser/content/browser-addons.js:1663
onDOMContentLoaded chrome://browser/content/browser-init.js:222

[filips123]

I think that error in the log is unrelated.

I've fixed that the dialog should no longer appear and the link should automatically open. This will be available in the next release.