[Regression] Immutable runtime fails to build

[pwall2222]

Description

Commit 192a7b4 introduces a regression on immutable-runtime,

Inside components/runtime.rs, the link method got changed from a feature to a requirement on linux, so if you try to build immutable-runtime, it will error out, because the method was not intended for that feature.

PWAsForFirefox/native/src/components/runtime.rs

Lines 355 to 365 in 192a7b4

	#[cfg(platform_linux)]
	pub fn link(&self) -> Result<()> {
	use std::fs::{copy, create_dir_all};
	use std::os::unix::fs::symlink;
	use crate::storage::Storage;
	let dirs = ProjectDirs::new()?;
	let mut storage = Storage::load(&dirs)?;
	self.uninstall()?;

Because obviously, immutable-runtime has no uninstall attribute.

PWAsForFirefox/native/src/components/runtime.rs

Lines 405 to 406 in 192a7b4

	#[cfg(not(feature = "immutable-runtime"))]
	pub fn uninstall(&self) -> Result<()> {

Steps to Reproduce

Build with immutable-runtime.

Suggestion

Add immutable-runtime to Github action tests.

Additional Information

Cargo logs:

 > error[E0599]: no method named `uninstall` found for reference `&Runtime` in the current scope
 >    --> src/components/runtime.rs:365:14
 >     |
 > 365 |         self.uninstall()?;
 >     |              ^^^^^^^^^ method not found in `&Runtime`

[filips123]

I've already wanted to add this to GitHub Actions tests for some time, but couldn't really decide what's the best way of doing it. I guess it's now time...

Currently, linked runtime won't work on Nix because it relies on a specific hardcoded path to Firefox, but once it is improved to support arbitrary paths, it should be allowed together with immutable runtime to allow users to use a different Firefox version/fork as a runtime, right?

[filips123]

For now, I've disabled linked runtime when immutable runtime is enabled, so it should now build properly. I still haven't added immutable runtime to GitHub Actions though, as I want to have this version released soon, as it contains some other important fixes. But I plan to add it in the future, and also make immutable and linked runtime work together.