fix: DotNetSdkValidator failed when using CsProjClassicNetToolchain

filzrev · filzrev · commit d0f63ecfec30 · 2025-12-05T12:51:19.000+09:00
diff --git a/src/BenchmarkDotNet/Validators/DotNetSdkValidator.cs b/src/BenchmarkDotNet/Validators/DotNetSdkValidator.cs
@@ -32,7 +32,11 @@ public static IEnumerable<ValidationError> ValidateCoreSdks(string? customDotNet
 
         public static IEnumerable<ValidationError> ValidateFrameworkSdks(BenchmarkCase benchmark)
         {
-            var requiredSdkVersion = benchmark.GetRuntime().RuntimeMoniker.GetRuntimeVersion();
+            var targetRuntime = benchmark.Job.Environment.HasValue(EnvironmentMode.RuntimeCharacteristic)
+                ? benchmark.Job.Environment.Runtime
+                : ClrRuntime.GetTargetOrCurrentVersion(benchmark.Descriptor.WorkloadMethod.DeclaringType.Assembly);
+            var requiredSdkVersion = targetRuntime.RuntimeMoniker.GetRuntimeVersion();
+
             var installedVersionString = cachedFrameworkSdks.Value.FirstOrDefault();
             if (installedVersionString == null || Version.TryParse(installedVersionString, out var installedVersion) && installedVersion < requiredSdkVersion)
             {

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,11 @@ public static IEnumerable<ValidationError> ValidateCoreSdks(string? customDotNet`
`32`	`32`
`33`	`33`	`public static IEnumerable<ValidationError> ValidateFrameworkSdks(BenchmarkCase benchmark)`
`34`	`34`	`{`
`35`		`- var requiredSdkVersion = benchmark.GetRuntime().RuntimeMoniker.GetRuntimeVersion();`
	`35`	`+ var targetRuntime = benchmark.Job.Environment.HasValue(EnvironmentMode.RuntimeCharacteristic)`
	`36`	`+ ? benchmark.Job.Environment.Runtime`
	`37`	`+ : ClrRuntime.GetTargetOrCurrentVersion(benchmark.Descriptor.WorkloadMethod.DeclaringType.Assembly);`
	`38`	`+ var requiredSdkVersion = targetRuntime.RuntimeMoniker.GetRuntimeVersion();`
	`39`	`+`
`36`	`40`	`var installedVersionString = cachedFrameworkSdks.Value.FirstOrDefault();`
`37`	`41`	`if (installedVersionString == null \|\| Version.TryParse(installedVersionString, out var installedVersion) && installedVersion < requiredSdkVersion)`
`38`	`42`	`{`