Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-duplicate-spread-property: handle destructuring assignments #347

Closed
ajafff opened this issue Jul 18, 2018 · 1 comment
Closed

no-duplicate-spread-property: handle destructuring assignments #347

ajafff opened this issue Jul 18, 2018 · 1 comment

Comments

@ajafff
Copy link
Member

ajafff commented Jul 18, 2018

Only makes sense after renaming in #344

The rule currently ignores the LHS of destructuring assignments. But these could also be checked:

var v: any;
({v, ...{v}} = get<Record<string, any>>());

This just needs an appropriate error message.

OTOH {v, ...{v}} could be simplified to {v, v} by #325

@ajafff
Copy link
Member Author

ajafff commented Jul 18, 2018

conclusion: this is not the responsibility of this rule -> implement in no-useless-destructuring in #325

@ajafff ajafff closed this as completed Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant