Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle ambient class properties #677

Open
ajafff opened this issue Jan 10, 2020 · 1 comment
Open

handle ambient class properties #677

ajafff opened this issue Jan 10, 2020 · 1 comment
Labels
upstream compatibility Changes needed to support new/upcoming language features or API changes in the TypeScript compiler

Comments

@ajafff
Copy link
Member

ajafff commented Jan 10, 2020

To support ES class instance fields, TypeScript introduced a new declare prop: T; syntax to declare a property on a derived class without using Define semantics to override it.

We need to make sure that we correctly handle the declare modifier on property declarations.
@ajafff ajafff added the upstream compatibility Changes needed to support new/upcoming language features or API changes in the TypeScript compiler label Jan 10, 2020
@ajafff
Copy link
Member Author

ajafff commented Jan 10, 2020

no-useless-declare can add a check to disallow declare prop: T; in an ambient class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream compatibility Changes needed to support new/upcoming language features or API changes in the TypeScript compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajafff