Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support for override? #49

Closed
mlhaufe opened this issue May 6, 2020 · 2 comments
Closed

TypeScript support for override? #49

mlhaufe opened this issue May 6, 2020 · 2 comments
Assignees
Labels
feature/override The override decorator question Further information is requested requirement An assertion or property that must be fulfilled
Milestone

Comments

@mlhaufe mlhaufe added question Further information is requested requirement An assertion or property that must be fulfilled azure migrated feature/override The override decorator labels May 6, 2020
@mlhaufe mlhaufe self-assigned this May 6, 2020
@mlhaufe mlhaufe mentioned this issue May 6, 2020
13 tasks
@mlhaufe mlhaufe changed the title TypeScript support? TypeScript support for override? Jun 3, 2020
@mlhaufe
Copy link
Contributor Author

mlhaufe commented Apr 14, 2021

TypeScript 4.3 has just introduced an override declaration:

https://devblogs.microsoft.com/typescript/announcing-typescript-4-3-beta/#override-and-the-noimplicitoverride-flag

The relationship of this new feature with @override needs to be documented.

The TypeScript feature does not subsume @override as this library supports plain JavaScript as well.

The README should be updated to explain the difference and why @override should still be used

@mlhaufe mlhaufe added this to the v0.20.0 milestone Apr 14, 2021
@mlhaufe mlhaufe modified the milestones: v0.20.0, v0.21.0 Apr 22, 2021
@mlhaufe
Copy link
Contributor Author

mlhaufe commented May 9, 2021

Closed as duplicate of #52

@mlhaufe mlhaufe closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/override The override decorator question Further information is requested requirement An assertion or property that must be fulfilled
Projects
None yet
Development

No branches or pull requests

1 participant