Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement non-promovables and promovables chess piece class #54

Open
finicu212 opened this issue Aug 16, 2021 · 0 comments
Open

Implement non-promovables and promovables chess piece class #54

finicu212 opened this issue Aug 16, 2021 · 0 comments
Labels
good first issue Good for newcomers refactor

Comments

@finicu212
Copy link
Owner

finicu212 commented Aug 16, 2021 •
edited
Loading

Purpose: further abstractization

Currently chess pieces are hard-coded whether or not they're promovable, inside of their Piece::canPromote (false or true).

Pawn <- PromovablePiece <- Piece

Rook, Knight, etc <- NonPromovablePiece (is this needed? check if can simply inherit from Piece) <- Piece

Get rid of Piece::canPromote
@finicu212 finicu212 added good first issue Good for newcomers refactor labels Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@finicu212