Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdc3.entity.fileAttachment is only defined inline in the fdc3.message schema and example has wrong type #1255

Closed
kriswest opened this issue Jul 9, 2024 · 0 comments · Fixed by #1261
Labels
bug Something isn't working Context Data & Intents Contexts & Intents Discussion Group context-data FDC3 Context Data Working Group
Milestone

Comments

@kriswest
Copy link
Contributor

kriswest commented Jul 9, 2024

While working on generating context documentation from schemas I noticed that the fdc3.message type defines an fdc3.entity.fileAttachment type inline:

"const": "fdc3.entity.fileAttachment"

and the type name does not agree with that used in the example (fdc3.fileAttachment):

"type": "fdc3.fileAttachment",

FDC3 context types should each have their own definition and schema to make them usable and to properly reserve the type name. Hence, this definition should be separated out into its own schema and be referenced into fdc3.message.

@Yannick-Malins & @mistryvinay

@kriswest kriswest added bug Something isn't working context-data FDC3 Context Data Working Group Context Data & Intents Contexts & Intents Discussion Group labels Jul 9, 2024
@mistryvinay mistryvinay linked a pull request Jul 16, 2024 that will close this issue
@kriswest kriswest added this to the 2.2 candidates milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Context Data & Intents Contexts & Intents Discussion Group context-data FDC3 Context Data Working Group
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant