Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntentMetadata displayName should be nullable #1264

Closed
bingenito opened this issue Jul 16, 2024 · 1 comment · Fixed by #1280
Closed

IntentMetadata displayName should be nullable #1264

bingenito opened this issue Jul 16, 2024 · 1 comment · Fixed by #1280
Labels
api FDC3 API Working Group deprecation Deprecating or removing features post deprecation

Comments

@bingenito
Copy link
Member

Question Area

[ ] App Directory
[ ] API
[x] Context Data
[ ] Intents
[ ] Use Cases
[ ] Other

Question

Given that IntentMetadata dispayName was marked deprecated, should the definition be changed to make it nullable?
@kriswest kriswest mentioned this issue Jul 22, 2024
Merged
@kriswest
Copy link
Contributor

Yes, it should be optional

@kriswest kriswest changed the title Question: Should IntentMetadata displayName be nullable IntentMetadata displayName should be nullable Jul 22, 2024
@kriswest kriswest added api FDC3 API Working Group deprecation Deprecating or removing features post deprecation labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api FDC3 API Working Group deprecation Deprecating or removing features post deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make IntentMetadata.displayName optional as its deprecated finos/FDC3
2 participants
@kriswest @bingenito