Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate es6-style functions and fdc3Ready function in methods.ts #1402

Closed
kriswest opened this issue Oct 25, 2024 · 0 comments · Fixed by #1403 or #1191
Closed

Deprecate es6-style functions and fdc3Ready function in methods.ts #1402

kriswest opened this issue Oct 25, 2024 · 0 comments · Fixed by #1403 or #1191
Labels
api FDC3 API Working Group deprecation Deprecating or removing features post deprecation FDC3 for Web Browsers

Comments

@kriswest
Copy link
Contributor

kriswest commented Oct 25, 2024

The methods.ts file in the FDC3 codebase provides wrapper functions FDC3 Desktop Agent API calls, allowing individual calls to be imported from the library. These calls check that window.fdc3 is present and resolve to an error if not, via an fdc3Ready function. The purpose of that function is superseded by the new getAgent function specified in the FDC3 for the Web PR #1191, whilst a reference to an individual function from the Desktop Agent API can also be achieved by destructuring.

As discussed at #1400, these calls appear to be of no significant utility (from FDC3 2.2 onwards) and they should be deprecated and removed in a future FDC3 major version (FDC3 3.0).

@kriswest kriswest added api FDC3 API Working Group deprecation Deprecating or removing features post deprecation FDC3 for Web Browsers labels Oct 25, 2024
@kriswest kriswest linked a pull request Oct 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group deprecation Deprecating or removing features post deprecation FDC3 for Web Browsers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant