Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete implementation of SessionStorage retrieval in FDC3 for the Web implementation #1433

Open
kriswest opened this issue Nov 12, 2024 · 0 comments · May be fixed by #1466
Open

Complete implementation of SessionStorage retrieval in FDC3 for the Web implementation #1433

kriswest opened this issue Nov 12, 2024 · 0 comments · May be fixed by #1466
Labels
enhancement New feature or request FDC3 for Web Browsers javascript Pull requests that update Javascript code
Milestone

Comments

@kriswest
Copy link
Contributor

kriswest commented Nov 12, 2024

The implementation of Session Storage retrieval and the constraining of methods of re-connecting to the desktop agent is not fully implemented in the FDC3 for the Web project. If stored data is found for the specified appId, then discovery methods should be limited to the previous type used (from the 4 defined, see https://deploy-preview-1191--fdc3.netlify.app/docs/next/api/ref/GetAgent#persisted-connection-data). E.g. if the FAILOVER type was found, the failover function should be run immediately, whereas if PROXY_URL is found, with an agentUrl set, then an iframe should be injected with that URL etc..

Handling of the stored data can be found at:

retrieveInstanceUuid(): string | undefined {
const detailsStr = globalThis.sessionStorage.getItem(this.sessionKey())
if (detailsStr) {
const details = JSON.parse(detailsStr) as DesktopAgentDetails
if (details.agentType == WebDesktopAgentType.ProxyParent) {
return details.instanceUuid
}
}
return undefined;
}

It is currently limited to retrieval of an instanceUuid in 1 of the 4 cases and is not affecting discovery as specified.

The final implementation will also be affected by #1430 which will need to change the structure of the data stored.

@kriswest kriswest added enhancement New feature or request javascript Pull requests that update Javascript code FDC3 for Web Browsers labels Nov 12, 2024
@kriswest kriswest added this to the 2.2 milestone Nov 12, 2024
@kriswest kriswest linked a pull request Dec 10, 2024 that will close this issue
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FDC3 for Web Browsers javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant