Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand relational grammar to allow dashes in schema names #229

Open
epsstan opened this issue Jun 7, 2021 · 0 comments
Open

Expand relational grammar to allow dashes in schema names #229

epsstan opened this issue Jun 7, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@epsstan
Copy link
Contributor

epsstan commented Jun 7, 2021

Feature Request

Expand relational grammar to allow dashes in schema names.

Description of Problem:

In some databases/dataservices (e.g BigQuery), the schema name does not allow "_" (underscore) but does allow "-" (dash).

Using "-" in a schema name results in a compilation error.

Potential Solutions:

The grammar defines "schema" to be an "identifier" [1]. "identifier" does not include dash (-). The grammar should be change to include "-" (dash) for schema names.

[1] https://github.com/finos/legend-pure/blob/master/legend-pure-m2-store-relational/src/main/antlr4/org/finos/legend/pure/m2/relational/serialization/grammar/v1/antlr/RelationalParser.g4#L21

@epsstan epsstan added the enhancement New feature or request label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant